Sherlock WAGMI #2 Contest Note Sharing

Contest dates: 10/16/23 - 10/23/23

Disclaimer

I do not own or endorse the code presented below. This is PURELY for educational purposes. Enjoy!

Impressions

Codebase was well written and in-line comments were good. Design structures where setup to be secure by default indicating good contract design. The only major portion missing was secondary documentation. A majority of issues were very small oversights and were quick fixes. Codebase was very secure given the quick dev time, which indicates competent and skilled developers.

Files with Notes

/contracts/LiquidityBorrowingManager.sol

/contracts/Vault.sol

/contracts/abstract/ApproveSwapAndPool.sol

/contracts/abstract/DailyRateAndCollateral.sol

/contracts/abstract/LiquidityManager.sol

/contracts/libraries/ExternalCall.sol

/contracts/libraries/Keys.sol